bad buf_getbyte patch

Erik Hovland erik at hovland.org
Wed Jan 19 06:46:14 WST 2005


I am sure everyone gets the idea. But I wanted to have a patch in the
mail archive which was appliable straight away.

E

On Tue, Jan 18, 2005 at 12:06:34PM -0800, David Horwitt wrote:
> I created a workaround/fix for my bad buf_getbyte problem:
> 
> *** svr-chansession.c   2005-01-11 13:14:54.000000000 -0800
> --- svr-chansession.c.orig      2005-01-03 01:24:04.000000000 -0800
> ***************
> *** 439,445 ****
> 
>         if (len == 0) {
>                 TRACE(("leave get_termmodes: empty terminal modes string"))
> -               return;
>         }
> 
>         while (((opcode = buf_getbyte(ses.payload)) != 0x00) && opcode <= 
>         159) {
> --- 439,444 ----
> 
> This seems to work OK w/out ill effects; the TRACE message implies that the 
> return that I added may have
> been intended all along.
> 
> Cheers,
> David Horwitt
> 
> 

-- 
Erik Hovland
mail: erik AT hovland DOT org
web: http://hovland.org/
PGP/GPG public key available on request
-------------- next part --------------
--- svr-chansession.c.orig	2005-01-18 14:43:11.548605000 -0800
+++ svr-chansession.c	2005-01-18 14:43:46.397009000 -0800
@@ -439,6 +439,7 @@
 
 	if (len == 0) {
 		TRACE(("leave get_termmodes: empty terminal modes string"))
+		return;
 	}
 
 	while (((opcode = buf_getbyte(ses.payload)) != 0x00) && opcode <= 159) {


More information about the Dropbear mailing list