[PATCH] dropbear-051: uClinux vfork
Jamie Lokier
jamie at shareable.org
Sat Sep 20 23:59:56 WST 2008
Farrell Aultman wrote:
> Between dropbear-047 and dropbear-051 changes were made that
> accounted for the fact that uClinux needs to use vfork instead of
> fork. However, fork was not replaced with vfork in all places. I
> moved the conditional preproccessor check for uClinux into the
> includes.h file, so that fork is always replaced with vfork in all
> of the dropbear code when compiling for uClinux. A side effect is
> that the code is cleaner since you just call fork without wrapping
> it every time with a conditional preprocessor check.
Have you checked that it's safe to call vfork in all those places?
vfork is not always a safe replacement for fork, even on uClinux where
fork doesn't work.
-- Jamie
More information about the Dropbear
mailing list