[PATCH 15/16] runopts: There's no reason to make a duplicate of "unknown"

Michael Witten mfwitten at gmail.com
Tue Dec 8 07:02:11 AWST 2015


Date: Sat, 7 Nov 2015 17:13:01 -0000
The variable `*cli_opts.own_user is of type `const char', and it doesn't seem to be freed anywhere.
---
 cli-runopts.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cli-runopts.c b/cli-runopts.c
index e8cb313..c4cd12c 100644
--- a/cli-runopts.c
+++ b/cli-runopts.c
@@ -706,7 +706,7 @@ static void fill_own_user() {
 		cli_opts.own_user = m_strdup(pw->pw_name);
 	} else {
 		dropbear_log(LOG_INFO, "Warning: failed to identify current user. Trying anyway.");
-		cli_opts.own_user = m_strdup("unknown");
+		cli_opts.own_user = "unknown";
 	}
 
 }
-- 
2.4.3



More information about the Dropbear mailing list