scp in dropbearmulti?

[Rob Landley]

On Friday 02 October 2009 08:07:40 Matt Johnston wrote:
> While I'm considering build-related issues - would anyone
> have a problem if I converted all the #ifdefs related to
> options.h into #if statements, to make it easier to override
> options on the commandline?

CFLAGS="-DWALRUS=0" you mean?

> Rather than
>
> #define ENABLE_CLI_PROXYCMD
>
> it'd become
>
> #ifndef ENABLE_CLI_PROXYCMD
> #define ENABLE_CLI_PROXYCMD 1
> #end
>
> etc.

Having them always #defined to 0/1 also means you can use if() in your code 
instead of #ifdef, and let dead code elimination remove the unreachable bits.  
This means everything's always syntax checked the same way no matter your 
config, so you don't get config-dependent build breaks.  (Trick I picked up from 
the linux kernel.)

Rob
-- 
Latency is more important than throughput. It's that simple. - Linus Torvalds