[PATCH 02/16] scp: Have `fatal()' append a newline to the message

Michael Witten mfwitten at gmail.com
Tue Dec 8 06:51:18 AWST 2015


Date: Wed, 4 Nov 2015 20:33:19 -0000
It would seem that it's standard practice not to include a newline in the message
text, but that results in poor formatting, as a shell's command line then begins
on the line of the error message itself.

This commit simply instructs `fatal()' to append a newline after the message,
which should be suitable behavior for all of the invocations I've come across.
---
 scpmisc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scpmisc.c b/scpmisc.c
index ec4df35..ea5b735 100644
--- a/scpmisc.c
+++ b/scpmisc.c
@@ -223,6 +223,7 @@ void fatal(char* fmt,...)
 	va_start(args, fmt);
 	vfprintf(stderr, fmt, args);
 	va_end(args);
+	fputc('\n', stderr);
 	exit(255);
 }
 
-- 
2.4.3



More information about the Dropbear mailing list