MIN_RSA_KEYLEN compare goes wrong

[Matt Johnston]

Hi Hans,

Sorry I missed replying to this message a while ago.

What program created the key? As far as I can tell the test
is correct, the top bit might be unset?

Cheers,
Matt

On Thu, Aug 27, 2020 at 07:36:26AM +0200, Hans Harder wrote:
> HI,
> 
> I noticed that I got warnings that the RSA key was too short.
> Further investigation showed that I was using a 1024 bits RSA key but
> the mp_count_bits function return 1023 count (probably 0 based)
> 
> in rsa.c  it states:    if (mp_count_bits(key->n) < MIN_RSA_KEYLEN)
> 
> Is this intentional  or should I just define the MIN_RSA_KEYLEN as
> 1023 instead of the 1024 now in sysoptions.h
> 
> Hans