<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi there,<div class=""><br class=""></div><div class="">Just wanting to let you know that it looks like <a href="https://github.com/mkj/dropbear/commit/6e0b539e9ca0b5628c6c5a3d118ad6a2e79e8039" class="">this commit</a> (<span style="color: rgb(68, 77, 86); font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, Courier, monospace; background-color: rgb(255, 255, 255);" class="">6e0b539e9ca0b5628c6c5a3d118ad6a2e79e8039</span>) renders key-based auth inoperable, as in the “checkpubkey” function it is now impossible for “ret” to be changed from “DROPBEAR_FAILURE”, so you end up with key auth being rejected with no stated reason when built with DEBUG_TRACE enabled.</div><div class=""><br class=""></div><div class="">It was formerly relying directly upon <a href="https://github.com/mkj/dropbear/commit/6e0b539e9ca0b5628c6c5a3d118ad6a2e79e8039#diff-20756035b9b25f61dcc641e0854861d3L348" class="">the return value of cmp_base64_key</a>.</div><div class=""><br class=""></div><div class="">I’ve submitted <a href="https://github.com/mkj/dropbear/pull/51" class="">a Pull Request (#51)</a> which fixes this by relying upon the return value of the checkpubkey_line function which was introduced by <span style="color: rgb(68, 77, 86); font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, Courier, monospace; background-color: rgb(255, 255, 255);" class="">6e0b539e</span>.</div><div class="">
<br class="">Thanks,<br class="">–Jessica
</div>
<br class=""></body></html>